Merged
Conversation
Member
Author
|
CC @UebelAndre |
illicitonion
approved these changes
Feb 25, 2021
UebelAndre
requested changes
Feb 25, 2021
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Sounds good. I'm curious how you actually ensure you're trying to enable more. If there's an automated way to remind you you're not testing everything or try to enable tests and see if something passes based on some change.
Member
Author
I don't think they will be fixed accidentally, so a system automatically checking if they pass won't be very useful. I'll create issues for them and we should try to fix them soon. |
hlopko
force-pushed
the
enable_windows
branch
from
4eae91b to
9c5828a
Compare
This was referenced Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized we don't run tests on Windows. This PR fixes that. While there I also enabled tests on RBE.