Skip to content

add CXX var to configure cpp compiler#928

Merged
UebelAndre merged 1 commit intobazelbuild:mainfrom
DXist:path_to_cxx_executable
Sep 6, 2021
Merged

add CXX var to configure cpp compiler#928
UebelAndre merged 1 commit intobazelbuild:mainfrom
DXist:path_to_cxx_executable

Conversation

@DXist
Copy link
Copy Markdown
Contributor

@DXist DXist commented Sep 6, 2021

I use cpp crate to integrate Rust and C++ code in my project which depends on cc crate.

cc relies on CXX env variable to find cpp compiler.

This PR sets this env variable along with CC.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Sep 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Sep 6, 2021
Copy link
Copy Markdown
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very reasonable :) If we can get CLA bot happy, this is should be good to go!

@DXist DXist force-pushed the path_to_cxx_executable branch from f987495 to 94ac02d Compare September 6, 2021 15:17
@google-cla google-cla Bot added cla: yes and removed cla: no labels Sep 6, 2021
@DXist
Copy link
Copy Markdown
Contributor Author

DXist commented Sep 6, 2021

fixed commiter email, signed the CLA

@UebelAndre UebelAndre merged commit aef1128 into bazelbuild:main Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants