add CXX var to configure cpp compiler#928
Merged
UebelAndre merged 1 commit intobazelbuild:mainfrom Sep 6, 2021
Merged
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
illicitonion
approved these changes
Sep 6, 2021
Collaborator
illicitonion
left a comment
There was a problem hiding this comment.
Seems very reasonable :) If we can get CLA bot happy, this is should be good to go!
f987495 to
94ac02d
Compare
Contributor
Author
|
fixed commiter email, signed the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use cpp crate to integrate Rust and C++ code in my project which depends on
cccrate.ccrelies on CXX env variable to findcppcompiler.This PR sets this env variable along with
CC.