A11y: focus first button in webUSB mode #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python-main.js
Outdated
Comment on lines
591
to
592
| var button = $('#command-download'); | ||
| var otherButton = $('#command-flash'); |
Collaborator
There was a problem hiding this comment.
These variables are created here but never used?
Contributor
Author
There was a problem hiding this comment.
whoops. a previous experiment that I left in :) Have now removed
microbit-carlos
approved these changes
Jan 14, 2020
Collaborator
microbit-carlos
left a comment
microbit-carlos
left a comment
There was a problem hiding this comment.
Tested and all good 👍
Thanks Mark!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus on Flash button when esc key is pressed when in webUSB mode
closes https://github.com/microbit-foundation/platform-software-issue-tracker/issues/594