Add site comparison of expected vs observed#245
Merged
FerriolCalvet merged 10 commits intodevfrom Feb 3, 2025
Merged
Conversation
- to be agreed - not tested
- add VAF distortion sq metrics
- use poisson distribution to assign pvalue
- not tested
FerriolCalvet
commented
Feb 3, 2025
Collaborator
Author
FerriolCalvet
left a comment
There was a problem hiding this comment.
updates look good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
human generated summary
AI generated summary
This pull request includes significant changes to the
omegaconfiguration and workflow files to streamline the process and remove redundant steps. The most important changes include adding new configurations forSUBSETOMEGAMULTI, removing configurations related toomega_vaf_distorsioned, and updating theomegaworkflow to incorporate the newSUBSETOMEGAMULTIandSITECOMPARISONMULTIsteps.Configuration Changes:
SUBSETOMEGAMULTIwith specific filters and output format settings inconf/tools/omega.config.omega_vaf_distorsionedincludingPREPROCESSINGRED,ESTIMATORRED,SUBSETOMEGA_REDUCED,PREPROCESSINGEXP,ESTIMATOREXP,SUBSETOMEGA_EXPANDED,PREPROCESSINGOK,ESTIMATOROK, andSUBSETOMEGA_OKinconf/tools/omega.config.Workflow Changes:
SUBSETOMEGAMULTIandSITECOMPARISONMULTImodules tosubworkflows/local/omega/main.nf. [1] [2]OMEGA_ANALYSISworkflow to includeSUBSETOMEGAMULTIandSITECOMPARISONMULTIsteps, ensuring they are properly integrated with existing steps. This includes joiningSUBSETOMEGAMULTIoutput withABSOLUTEMUTABILITIESandABSOLUTEMUTABILITIESGLOBALLOCoutputs and setting them for further comparison. [1] [2] [3]