Skip to content

Create single environment for bin python scripts.#267

Merged
FedericaBrando merged 7 commits intodevfrom
dev-create-env-for-bin
Mar 29, 2025
Merged

Create single environment for bin python scripts.#267
FedericaBrando merged 7 commits intodevfrom
dev-create-env-for-bin

Conversation

@FedericaBrando
Copy link
Member

@FedericaBrando FedericaBrando commented Mar 27, 2025

This pull request includes updates to several Nextflow processes to standardize the container image used across the pipeline. The main change involves replacing various container images with a single unified container image.

steps:

  • create docker recipe
  • changed shebangs of python scripts
  • changed container for each python process
  • tested pipeline not failing
  • checked results with current expected

Tests are on-going.

closes #225

@FedericaBrando FedericaBrando requested a review from Copilot March 27, 2025 17:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 55 out of 75 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • modules/local/annotatedepth/main.nf: Language not supported
  • modules/local/bbgtools/oncodrive3d/preprocessing/main.nf: Language not supported
  • modules/local/bbgtools/sitecomparison/main.nf: Language not supported
  • modules/local/blacklistmuts/main.nf: Language not supported
  • modules/local/combine_sbs/main.nf: Language not supported
  • modules/local/compute_mutability/main.nf: Language not supported
  • modules/local/compute_profile/main.nf: Language not supported
  • modules/local/compute_trinucleotide/main.nf: Language not supported
  • modules/local/computemutrate/main.nf: Language not supported
  • modules/local/dna2protein/main.nf: Language not supported
  • modules/local/dnds/preprocess/main.nf: Language not supported
  • modules/local/expand_regions/main.nf: Language not supported
  • modules/local/filterbed/main.nf: Language not supported
  • modules/local/filtermaf/main.nf: Language not supported
  • modules/local/group_genes/main.nf: Language not supported
  • modules/local/indels/main.nf: Language not supported
  • modules/local/mergemafs/main.nf: Language not supported
  • modules/local/mutation_matrix/main.nf: Language not supported
  • modules/local/mutations2sbs/main.nf: Language not supported
  • modules/local/plot/omega/main.nf: Language not supported

@FedericaBrando FedericaBrando self-assigned this Mar 27, 2025
@FedericaBrando FedericaBrando added the code-review 👩‍💻 Tasks associated with the code-review label Mar 27, 2025
@FedericaBrando FedericaBrando added this to the First release milestone Mar 27, 2025
@FedericaBrando FedericaBrando requested a review from Copilot March 28, 2025 15:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 57 out of 77 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • modules/local/annotatedepth/main.nf: Language not supported
  • modules/local/bbgtools/oncodrive3d/plot_chimerax/main.nf: Language not supported
  • modules/local/bbgtools/oncodrive3d/preprocessing/main.nf: Language not supported
  • modules/local/bbgtools/sitecomparison/main.nf: Language not supported
  • modules/local/blacklistmuts/main.nf: Language not supported
  • modules/local/combine_sbs/main.nf: Language not supported
  • modules/local/compute_mutability/main.nf: Language not supported
  • modules/local/compute_profile/main.nf: Language not supported
  • modules/local/compute_trinucleotide/main.nf: Language not supported
  • modules/local/computemutrate/main.nf: Language not supported
  • modules/local/dna2protein/main.nf: Language not supported
  • modules/local/dnds/preprocess/main.nf: Language not supported
  • modules/local/expand_regions/main.nf: Language not supported
  • modules/local/filterbed/main.nf: Language not supported
  • modules/local/filtermaf/main.nf: Language not supported
  • modules/local/group_genes/main.nf: Language not supported
  • modules/local/indels/main.nf: Language not supported
  • modules/local/mergemafs/main.nf: Language not supported
  • modules/local/mutation_matrix/main.nf: Language not supported
  • modules/local/mutations2sbs/main.nf: Language not supported

@FedericaBrando
Copy link
Member Author

Please give it a look!

@FedericaBrando FedericaBrando changed the title [DRAFT] Create single environment for bin python scripts. Create single environment for bin python scripts. Mar 28, 2025
Copy link
Collaborator

@FerriolCalvet FerriolCalvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!
If the final test with Seqera works you can merge it!

I guess that in a way we could keep track of the scripts whose container have change and create a list of all the ones that require updating the input handling with click, but I guess this is also part of the code review and you may want to address it one file at a time instead of a batch update

@FerriolCalvet
Copy link
Collaborator

also you are combining the use of single and double quotes for the containers, but I don't really care.
I comment it just in case you have a preference and want to make it uniform.

@FedericaBrando
Copy link
Member Author

FedericaBrando commented Mar 28, 2025

also you are combining the use of single and double quotes for the containers, but I don't really care.
I comment it just in case you have a preference and want to make it uniform.

good catch, I'll fix it

I guess that in a way we could keep track of the scripts whose container have change and create a list of all the ones that require updating the input handling with click, but I guess this is also part of the code review and you may want to address it one file at a time instead of a batch update

better a one-by-one update! It would also impact the processes and how you declare the params for the scripts

@FerriolCalvet
Copy link
Collaborator

True, it is a bigger thing! Sounds like a good plan.
Whenever I update some script, if I do I will take this into account but doing it in a one-by-one manner makes total sense.

@FedericaBrando FedericaBrando merged commit b290dc2 into dev Mar 29, 2025
@FedericaBrando FedericaBrando deleted the dev-create-env-for-bin branch March 29, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-review 👩‍💻 Tasks associated with the code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

code-review | environment for all bin scripts

3 participants