Create single environment for bin python scripts.#267
Conversation
- pytabix is an old and bugged version of tabix, deprecated. We should always use pysam one.
There was a problem hiding this comment.
Copilot reviewed 55 out of 75 changed files in this pull request and generated no comments.
Files not reviewed (20)
- modules/local/annotatedepth/main.nf: Language not supported
- modules/local/bbgtools/oncodrive3d/preprocessing/main.nf: Language not supported
- modules/local/bbgtools/sitecomparison/main.nf: Language not supported
- modules/local/blacklistmuts/main.nf: Language not supported
- modules/local/combine_sbs/main.nf: Language not supported
- modules/local/compute_mutability/main.nf: Language not supported
- modules/local/compute_profile/main.nf: Language not supported
- modules/local/compute_trinucleotide/main.nf: Language not supported
- modules/local/computemutrate/main.nf: Language not supported
- modules/local/dna2protein/main.nf: Language not supported
- modules/local/dnds/preprocess/main.nf: Language not supported
- modules/local/expand_regions/main.nf: Language not supported
- modules/local/filterbed/main.nf: Language not supported
- modules/local/filtermaf/main.nf: Language not supported
- modules/local/group_genes/main.nf: Language not supported
- modules/local/indels/main.nf: Language not supported
- modules/local/mergemafs/main.nf: Language not supported
- modules/local/mutation_matrix/main.nf: Language not supported
- modules/local/mutations2sbs/main.nf: Language not supported
- modules/local/plot/omega/main.nf: Language not supported
There was a problem hiding this comment.
Copilot reviewed 57 out of 77 changed files in this pull request and generated no comments.
Files not reviewed (20)
- modules/local/annotatedepth/main.nf: Language not supported
- modules/local/bbgtools/oncodrive3d/plot_chimerax/main.nf: Language not supported
- modules/local/bbgtools/oncodrive3d/preprocessing/main.nf: Language not supported
- modules/local/bbgtools/sitecomparison/main.nf: Language not supported
- modules/local/blacklistmuts/main.nf: Language not supported
- modules/local/combine_sbs/main.nf: Language not supported
- modules/local/compute_mutability/main.nf: Language not supported
- modules/local/compute_profile/main.nf: Language not supported
- modules/local/compute_trinucleotide/main.nf: Language not supported
- modules/local/computemutrate/main.nf: Language not supported
- modules/local/dna2protein/main.nf: Language not supported
- modules/local/dnds/preprocess/main.nf: Language not supported
- modules/local/expand_regions/main.nf: Language not supported
- modules/local/filterbed/main.nf: Language not supported
- modules/local/filtermaf/main.nf: Language not supported
- modules/local/group_genes/main.nf: Language not supported
- modules/local/indels/main.nf: Language not supported
- modules/local/mergemafs/main.nf: Language not supported
- modules/local/mutation_matrix/main.nf: Language not supported
- modules/local/mutations2sbs/main.nf: Language not supported
|
Please give it a look! |
FerriolCalvet
left a comment
There was a problem hiding this comment.
All looks good!
If the final test with Seqera works you can merge it!
I guess that in a way we could keep track of the scripts whose container have change and create a list of all the ones that require updating the input handling with click, but I guess this is also part of the code review and you may want to address it one file at a time instead of a batch update
|
also you are combining the use of single and double quotes for the containers, but I don't really care. |
good catch, I'll fix it
better a one-by-one update! It would also impact the processes and how you declare the params for the scripts |
|
True, it is a bigger thing! Sounds like a good plan. |
This pull request includes updates to several Nextflow processes to standardize the container image used across the pipeline. The main change involves replacing various container images with a single unified container image.
steps:
Tests are on-going.
closes #225