Skip to content

Separation of artifactual filter from somatic filter#280

Merged
FerriolCalvet merged 2 commits intodevfrom
279-separate-filtering-of-artifacts-from-filtering-of-somatic
Apr 10, 2025
Merged

Separation of artifactual filter from somatic filter#280
FerriolCalvet merged 2 commits intodevfrom
279-separate-filtering-of-artifacts-from-filtering-of-somatic

Conversation

@FerriolCalvet
Copy link
Collaborator

@FerriolCalvet FerriolCalvet commented Apr 10, 2025

Human summary

  • reordered blacklisting of mutations
  • add clean mutations module
  • tested

FIRST FILTER (for generating CLEANMUTATIONS)

{
    "DEPTH" : "ge 40",  "FILTER" : ["notcontains NM20", "notcontains p8", "notcontains n_rich", "notcontains cohort_n_rich_threshold", "notcontains cohort_n_rich", "notcontains no_pileup_support", "notcontains low_mappability", "notcontains not_covered"], "VAF_distorted_expanded_sq" : false
}

SECOND FILTER (for generating SOMATICMUTATIONS)

{
    "VAF" : "le 0.3",   "VAF_AM" : "le 0.3",    "vd_VAF" : "le 0.3",    "FILTER" : []
}

new diagram of this subworkflow

image

AI summary

This pull request introduces several significant updates to the mutation preprocessing workflow, focusing on the addition of new filtering steps and the refinement of existing processes. The main changes include adding new modules for cleaning and filtering mutations, updating configuration parameters, and modifying the workflow to incorporate these new steps.

Key Changes:

Workflow Enhancements:

  • Added new mutation cleaning and filtering steps (CLEANMUTATIONS and SOMATICMUTATIONS) to the workflow to refine mutation data before final processing. (subworkflows/local/mutationpreprocessing/main.nf) [1] [2]

Configuration Updates:

  • Introduced a new configuration parameter filter_criteria_somatic to specify filters for somatic mutations, and updated the description for filter_criteria. (nextflow.config)
  • Updated the schema to include filter_criteria_somatic and revised the description for filter_criteria. (nextflow_schema.json)

Module Additions:

  • Added new modules WRITEMAF, CLEANMUTATIONS, and SOMATICMUTATIONS to the process configuration to handle different stages of mutation filtering and output. (conf/modules.config)
  • Included the CLEANMUTATIONS module in the mutation preprocessing workflow to clean artifact mutations. (subworkflows/local/mutationpreprocessing/main.nf)

These changes collectively enhance the mutation preprocessing workflow by adding more granular control over mutation filtering and ensuring cleaner data for downstream analysis.

- reordered blacklisting of mutations
- add clean mutations module
- not tested
@FerriolCalvet FerriolCalvet linked an issue Apr 10, 2025 that may be closed by this pull request
@FerriolCalvet FerriolCalvet requested a review from Copilot April 10, 2025 12:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • conf/modules.config: Language not supported
  • nextflow.config: Language not supported
  • nextflow_schema.json: Language not supported
  • subworkflows/local/mutationpreprocessing/main.nf: Language not supported

- writemaf --> germline_somatic
- cleanmutations --> clean_germline_somatic
- somaticmutations --> clean_somatic
Copy link
Collaborator Author

@FerriolCalvet FerriolCalvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and tested

@FerriolCalvet FerriolCalvet merged commit 4deb170 into dev Apr 10, 2025
@FerriolCalvet FerriolCalvet deleted the 279-separate-filtering-of-artifacts-from-filtering-of-somatic branch April 10, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate filtering of artifacts from filtering of somatic

2 participants