Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (7)
- conf/bladder.config: Language not supported
- conf/modules.config: Language not supported
- conf/no_filter.config: Language not supported
- conf/tools/hdp_sig_extraction.config: Language not supported
- conf/tools/regressions.config: Language not supported
- nextflow.config: Language not supported
- nextflow_schema.json: Language not supported
Collaborator
Author
|
@FedericaBrando implemented with the no_filter param updating the definition of the ext.filters in the modules.config |
Collaborator
Author
|
sorry it is a dirtier PR this time haha 🙏🏻 |
Member
FedericaBrando
left a comment
There was a problem hiding this comment.
The implementation work and it's fine. I have some concerns regarding readability and use of reverse logic in booleans that may lead to confusion.
I've made a small comment in that regard.
Having said that, I think overall it does the job! Good Ferriol! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update the postprocessing annotation script so that it fails if the output contains duplicated rows.
AI generated summary
This pull request introduces several updates to configuration files and schema definitions, focusing on improving filtering logic, adding new parameters, and removing deprecated configurations. The most significant changes include refactoring the filtering process, introducing new parameters in the schema, and removing unused or redundant configurations.
Filtering logic updates:
conf/modules.configto dynamically construct filters based on theno_filterparameter and the presence of duplex counts (params.all_duplex_counts). This change simplifies and consolidates the filter logic.conf/no_filter.configfile, as its functionality is now integrated into the main filtering logic with theno_filterparameter.Schema updates:
nextflow_schema.json, includingomega_multi,no_filter,norm_file, andprior_file, to support additional configuration options and enhance flexibility. [1] [2] [3]confidence_levelparameter innextflow_schema.jsonfrom "high" to "med" to align with updated requirements.Configuration cleanup:
no_filterprofile fromnextflow.configsince theno_filterfunctionality is now handled by theno_filterparameter.RUNREGRESSIONSprocess inconf/modules.configfor better code clarity and maintainability.Additional improvements:
PREPARE_INPUTprocess inconf/tools/hdp_sig_extraction.configto include apublishDirdirective for organizing output files.RUN_HDP_CHAIN_SAMPLINGprocess to restrict it to specific file types (RData,txt,pdf).