Set minimum mutations per sample threshold#346
Merged
FerriolCalvet merged 2 commits intodevfrom Aug 26, 2025
Merged
Conversation
- same happens with groups that have less than a the chosen number of muts - set minimum to 0 - NOT tested
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable minimum mutations per sample threshold to control when individual sample analysis is performed. It sets a new parameter with a default value of 0 to ensure samples with no mutations are not excluded from analysis.
- Added configurable
min_muts_per_sampleparameter with default value of 0 - Modified mutation subset process to handle optional output when minimum threshold is not met
- Removed "notcontains p8" from default filter criteria
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nextflow_schema.json | Added schema definition for the new min_muts_per_sample parameter |
| nextflow.config | Added min_muts_per_samples parameter and updated filter criteria |
| modules/local/subsetmaf/main.nf | Modified process to accept minimum mutations parameter and made output optional |
| conf/modules.config | Applied minimum mutations parameter to SOMATICMUTATIONS process |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samples with no mutations are not analyzed individually