Fix/slurm23.02.1 compatible and retrocompatibility#6
Merged
FedericaBrando merged 5 commits intomasterfrom Apr 22, 2025
Merged
Conversation
Removing the "reserved" column, since it doesn't exist in slurm 23.02.1. (bbgcluster slurm is v16)
Older versions of Slurm use 'reserved', while newer versions use 'planned'.
FedericaBrando
force-pushed
the
fix/slurm23.02.1_compatible
branch
from
d5afc59 to
51dbabe
Compare
TODO: clean unusued globals
FedericaBrando
force-pushed
the
fix/slurm23.02.1_compatible
branch
from
51dbabe to
7fe640f
Compare
Member
Author
|
Things to do:
|
migrau
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes an enhancement for the
qmappackage - mostly to the slurm script in the executor. It checks slurm version and appends the proper flag to the STATUS_FORMAT.SLURM Executor Enhancements:
qmap/executor/slurm.py: Added a new method_get_slurm_version_majorto fetch the SLURM version and updatedgenerate_jobs_statusto use this method for determining the correct node state column. [1] [2]Placeholder Replacement:
qmap/executor/slurm.py: Introduced a placeholder inSTATUS_FORMATand replaced it dynamically based on the SLURM version. [1] [2]Tests
TODO