This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Add libuast, upgrade libuast API, bugfixing #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 2 commits
September 6, 2017 15:19
Contributor
Author
|
Looks like the new tests if failing with Python 3.4 which makes CI fails, I'll take a look. |
- Added error control which turns an ugly crash into a nice traceback (+ unittest).
- Migrated to `libuast` 0.2.0.
- Migrated to Google's C++ coding style
- Changed autorship to source{d} in the setup.py, updated email.
Whitespace
Fixed test
abeaumont
suggested changes
Sep 7, 2017
bblfsh/pyuast.c
Outdated
| PyMODINIT_FUNC PyInit_pyuast(void) | ||
| { | ||
| NodeIface iface = { | ||
| .InternalType = GetInternalType, |
Contributor
There was a problem hiding this comment.
I'd use InternalType, etc. instead of GetInternalType, etc. so be consistent with code in both libuast, its examples, client-go, etc.
bblfsh/pyuast.c
Outdated
| } | ||
|
|
||
| static PyMethodDef extension_methods[] = { | ||
| {"find", PyFind, METH_VARARGS, "Find a node in the UAST"}, |
Contributor
There was a problem hiding this comment.
I'd rename find to filter for consistency (I changed the name since we're not looking for a node, we're filtering the nodes in the tree that match some predicate.)
Contributor
Author
There was a problem hiding this comment.
Since we're not breaking backward compatibility 👍
Contributor
Author
|
Symbols renamed. |
abeaumont
approved these changes
Sep 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from: /pull/16 moved to my branch to continue the work.
All suggestions in the original PR have been implemented on this branch.
Other changes:
libuast0.2.0.