This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Pypi fix, versioned SDK, improved README #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2017 11:58
Changed import path, updated version
abeaumont
suggested changes
Sep 8, 2017
setup.py
Outdated
| sources.append('bblfsh/libuast/uast.c') | ||
| sources.append('bblfsh/libuast/roles.c') | ||
|
|
||
| # download c deoendencies |
Contributor
There was a problem hiding this comment.
unrelated, but s/deoendencies/dependencies/
bblfsh/pyuast.c
Outdated
| @@ -1,4 +1,4 @@ | |||
| #include "uast.h" | |||
| #include "libuast/uast.h" | |||
Contributor
There was a problem hiding this comment.
I don't think this is correct, since bblfsh is not in the include list.
Contributor
Author
There was a problem hiding this comment.
Yeah, cruft from one of my tests, works because gcc looks also form the source code file path, but unneeded.
Contributor
Author
|
Changes from review feedback (thanks!) done, I've also included a dependencies section in the readme stating the need for libxml2 header files. Travis is failing for some reason, I'll investigating it. |
abeaumont
approved these changes
Sep 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifest.infile so pypi doesn't remove some files.libuastdirectory is deleted before runningmake deps.Fixes #24.
Fixes #25.