handle timeout correctly #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current versions of bblfhd and client-go don't have any timeouts but a proxy (like nginx) can have one. In such case user will see standard "Bad Gateway" error. This commit doesn't change this behaviour but handles timeouts correctly. In case of client (or proxy) has cancelled a request it gets propagated to bblfsh. In case bblfsh would add default timeout in the future this commit handles it correctly too. Signed-off-by: Maxim Sukharev <max@smacker.ru>
dpordomingo
approved these changes
Apr 12, 2019
carlosms
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #187
Current versions of bblfhd and client-go don't have any timeouts
but a proxy (like nginx) can have one.
In such case user will see standard "Bad Gateway" error.
This commit doesn't change this behaviour but handles timeouts
correctly.
In case of client (or proxy) has cancelled a request it gets propagated
to bblfsh.
In case bblfsh would add default timeout in the future this commit
handles it correctly too.