Migrates to go-client #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se7entyse7en
force-pushed
the
go-client-migration
branch
from
e5f8793 to
a4bf0fe
Compare
Member
Author
|
For some reason, it seems that |
Signed-off-by: Lou Marvin Caraig <loumarvincaraig@gmail.com>
se7entyse7en
force-pushed
the
go-client-migration
branch
from
a4bf0fe to
bbd0c78
Compare
dpordomingo
approved these changes
Apr 16, 2019
Member
dpordomingo
left a comment
dpordomingo
left a comment
There was a problem hiding this comment.
LGTM
It seems that travis is fetching the proper branch, isn't it?
https://travis-ci.org/bblfsh/web/jobs/520705198#L606
Member
Author
Yup, I was having a problem before. I just made a dummy change just to have a different commit hash and rebuild the ci on travis. |
carlosms
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208.