Use LOG_LEVEL env value to set logrus log level #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se7entyse7en
requested changes
Oct 25, 2019
smacker
approved these changes
Oct 27, 2019
Collaborator
smacker
left a comment
smacker
left a comment
There was a problem hiding this comment.
ok. but I agree with Marvin that debug & tracing looks confusing.
Member
Author
|
Push forced: b7cc318
|
LOG_LEVEL can be any of debug, info, warning, error If bblfsh backend is ran with --debug flag, log level will be 'trace' Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
se7entyse7en
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #221
LOG_LEVELcan be any ofdebug,info,warning,errorIf bblfsh backend is run with
--debugflag, log level will betraceThis change is