Skip to content

Fix vega warnings #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
b-yogesh merged 13 commits into from
Nov 22, 2024
Merged

Fix vega warnings #37

b-yogesh merged 13 commits into from
Nov 22, 2024

Conversation

@b-yogesh
Copy link
Collaborator

@b-yogesh b-yogesh commented Nov 20, 2024 •
edited
Loading

Fixes the following vega warnings:

- Cannot add invalid signal listener. Error: Unrecognized signal name: "onClick"
- Infinite extent for field "a_start": [Infinity, -Infinity]
- Scale bindings are currently only supported for scales with unbinned, continuous domains.

@b-yogesh b-yogesh self-assigned this Nov 20, 2024
@b-yogesh b-yogesh marked this pull request as ready for review November 20, 2024 15:27
@b-yogesh b-yogesh requested a review from forman November 20, 2024 15:30
forman
forman requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have no clue what all this code is about.
Please comment why all this is done.

@b-yogesh b-yogesh requested a review from forman November 21, 2024 10:00
forman
forman requested changes Nov 21, 2024
View reviewed changes
@b-yogesh b-yogesh requested a review from forman November 22, 2024 13:29
forman
forman approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! However, after merging, I will move the new hook into a new module as it is very vega-specific.

@b-yogesh b-yogesh merged commit 0ae91f1 into main Nov 22, 2024
@b-yogesh b-yogesh deleted the yogesh-xxx-fix-vega-warnings branch November 22, 2024 13:34
b-yogesh added a commit that referenced this pull request Nov 22, 2024
@b-yogesh
Revert "Fix vega warnings (#37)"
4de65d0 
This reverts commit 0ae91f1.
@b-yogesh b-yogesh mentioned this pull request Nov 22, 2024
Merged
b-yogesh added a commit that referenced this pull request Nov 22, 2024
@b-yogesh
Revert "Fix vega warnings (#37)" (#48)
503417b 
This reverts commit 0ae91f1.
@b-yogesh b-yogesh mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@forman forman forman approved these changes

Assignees

@b-yogesh b-yogesh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@b-yogesh @forman