Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Dec 31, 2024

Added a few more grid mapping rules

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 97.15909% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.64%. Comparing base (e232629) to head (7703bed).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
xrlint/cli/main.py 84.61% 1 Missing and 1 partial ⚠️
xrlint/config.py 91.66% 1 Missing and 1 partial ⚠️
xrlint/plugins/core/rules/var_units_attr.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   92.92%   93.64%   +0.72%     
==========================================
  Files          40       46       +6     
  Lines        1272     1385     +113     
  Branches      158      180      +22     
==========================================
+ Hits         1182     1297     +115     
+ Misses         55       53       -2     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman marked this pull request as ready for review January 2, 2025 06:33
@forman forman merged commit c1f72a7 into main Jan 2, 2025
5 checks passed
@forman forman deleted the forman-grid_mapping_rules branch January 2, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants