PSP-6586 : List-view Tables: all text box search filters do not TRIM white space#5249
PSP-6586 : List-view Tables: all text box search filters do not TRIM white space#5249eddherrera wants to merge 2 commits intobcgov:devfrom
Conversation
|
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5249 |
asanchezr
left a comment
asanchezr
left a comment
There was a problem hiding this comment.
Please see the comments. Also, I did not see changes to a number of other filter-models. Did you ensure that values are trimmed for?
- ManagementActivityFilterModel
- ManagementFilterModel
- ContactFilterModel
- PropertyFilterModel
- ResearchFilterModel
- LeaseFilterModel
| AcquisitionFileNameOrNumber = model.AcquisitionFileNameOrNumber.Trim(), | ||
| ProjectNameOrNumber = model.ProjectNameOrNumber.Trim(), | ||
| OwnerName = model.OwnerName.Trim(), |
There was a problem hiding this comment.
do we always get empty strings here or should we check for nulls in the payload we get from the frontend?
ie - OwnerName = model.OwnerName?.Trim(),
| Pid = model.Pid, | ||
| Pin = model.Pin, |
There was a problem hiding this comment.
how about trimming PID and PIN?
| Address = model.Address?.Trim(), | ||
| FileNameOrNumberOrReference = model.FileNameOrNumberOrReference?.Trim(), |
There was a problem hiding this comment.
Oh I see you guard for nulls here - should be applied to all other places
Also PID/PID should be trimmed as well everywhere (this is the main source of copy/paste)
2 participants
No description provided.