Update bdb.#20
Merged
Merged
Conversation
Since last leveldown ports and discontinuation of leveldown (move to abstract), it's highly unlikely we will do full ports like before. Now we can make the changes permanent.
Add guards on calls to check if the database is open, other than iterator which are closed themselves.
Member
Author
|
Two memleaks were introduced by this PR and one was old (NewBloomFilterPolicy was not freed). Fixed both |
4f808f9 to
d940132
Compare
Member
Author
|
Iterators only method that is actively being used (Next) is behind the nexting_ guard. So it should be safe to use. If we want to make Seek async and add Prev then we will need to generalize this little bit more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on and closes #16
Main goal:
Other issues:
WriteBatchobject not synchronized #6, iterators are also unsafe to call w/o synchronization from the outside: https://github.com/google/leveldb/blob/068d5ee1a3ac40dabd00d211d5013af44be55bea/include/leveldb/iterator.h#L10-L13, add thread safety on those methods.Note:
patchesand integrate everything w/o them. Instead we will have to port necessary patches ourselves. (Still quite compatible, so should be easier)