WIP: Feature/issue 29 by bdelion · Pull Request #32 · bdelion/basic-weather-app

bdelion · 2019-10-30T11:14:10Z

No description provided.

codecov · 2019-10-30T11:15:29Z

Codecov Report

Merging #32 into develop will increase coverage by 15.37%.
The diff coverage is 72.82%.

@@             Coverage Diff              @@
##           develop      #32       +/-   ##
============================================
+ Coverage    54.46%   69.83%   +15.37%     
============================================
  Files           11       13        +2     
  Lines          213      242       +29     
  Branches         6        6               
============================================
+ Hits           116      169       +53     
+ Misses          96       72       -24     
  Partials         1        1

Impacted Files	Coverage Δ
...aining/java/basicweatherapp/owm/CoordLocation.java	`100% <ø> (ø)`
...ifiz/training/java/basicweatherapp/owm/Clouds.java	`100% <ø> (ø)`
...training/java/basicweatherapp/owm/SysInternal.java	`84.21% <ø> (ø)`
...va/basicweatherapp/BasicWeatherAppApplication.java	`0% <0%> (ø)`
...va/basicweatherapp/MessageTemplateReaderUtils.java	`0% <0%> (ø)`
...g/java/basicweatherapp/owm/TechnicalException.java	`100% <100%> (ø)`
...fiz/training/java/basicweatherapp/owm/Weather.java	`100% <100%> (ø)`
.../fifiz/training/java/basicweatherapp/owm/Wind.java	`100% <100%> (ø)`
.../fifiz/training/java/basicweatherapp/owm/Rain.java	`100% <100%> (ø)`
.../fifiz/training/java/basicweatherapp/owm/Snow.java	`100% <100%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775d13b...58f36e5. Read the comment docs.

For #29

✨ Make work again

⏪ Rollback on junit-jupiter

✅ Add json file for Rain and Snow Unit Tests

Fix #31

🚚 src-old sources

➕ org.apache.logging.log4j:log4j-slf4j-impl

🔊 Rework logs

bdelion · 2020-03-03T22:05:18Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 20
           

Complexity increasing per file
==============================
- src/test/java/fr/fifiz/training/app/java/own/OwmClientTest.java  2
- src/test/java/fr/fifiz/training/app/java/own/TestException.java  1
- src/main/java/fr/fifiz/training/app/java/owm/Rain.java  1
- src/test/java/fr/fifiz/training/app/java/own/WeatherResultStub.java  4
- src/main/java/fr/fifiz/training/app/java/owm/TechnicalException.java  1
- src/test/java/fr/fifiz/training/app/java/own/WeatherResultTest.java  1
- .mvn/wrapper/MavenWrapperDownloader.java  8
- src/main/java/fr/fifiz/training/app/java/owm/Wind.java  1
- src/main/java/fr/fifiz/training/app/java/owm/Weather.java  1
- src/main/java/fr/fifiz/training/app/java/owm/CoordLocation.java  1
- src/main/java/fr/fifiz/training/app/java/owm/Clouds.java  1
- src/main/java/fr/fifiz/training/app/java/owm/WeatherResult.java  1
- src/main/java/fr/fifiz/training/app/java/MessageTemplateReaderUtils.java  5
- src/main/java/fr/fifiz/training/app/java/owm/OwmClient.java  10
- src/main/java/fr/fifiz/training/app/java/BasicWeatherAppApplication.java  3
- src/main/java/fr/fifiz/training/app/java/owm/Snow.java  1
- src/test/java/fr/fifiz/training/app/java/BasicWeatherAppApplicationTests.java  1
- src/main/java/fr/fifiz/training/app/java/owm/SysInternal.java  1
- src/main/java/fr/fifiz/training/app/java/owm/Main.java  1
         

Clones added
============
- src/test/java/fr/fifiz/training/app/java/own/OwmClientTest.java  2

See the complete overview on Codacy

bdelion · 2020-03-03T22:05:24Z

+  }
+
+  @AfterEach
+  public void teardown() {


Issue found: You may have misspelled a JUnit framework method (setUp or tearDown)

bdelion · 2020-03-03T22:05:25Z

+  //
+  private static final String OWN_RESULT_CITY_NOT_FOUND = "owm_citynotfound.json";
+
+  WireMockServer wireMockServer;


Issue found: Use explicit scoping instead of the default package private level

bdelion · 2020-03-03T22:05:26Z

+        try {
+            downloadFileFromURL(url, outputFile);
+            System.out.println("Done");
+            System.exit(0);


Issue found: System.exit() should not be used in J2EE/JEE apps

bdelion · 2020-03-03T22:05:27Z

+    OwmClient client = new OwmClient(new URL(LOCAL_URL_MALFORMED
+        .replace(LOCAL_URL_PORT, String.valueOf(wireMockServer.port())).replace(LOCAL_URL_PATH, WEATHER_API_PATH)));
+    try {
+      WeatherResult weatherResult = client.getWeather();


Issue found: Avoid unused local variables such as 'weatherResult'.

bdelion · 2020-03-03T22:05:28Z

+
+        File outputFile = new File(baseDirectory.getAbsolutePath(), MAVEN_WRAPPER_JAR_PATH);
+        if(!outputFile.getParentFile().exists()) {
+            if(!outputFile.getParentFile().mkdirs()) {


Issue found: These nested if statements could be combined

bdelion · 2020-03-03T22:05:29Z

+	}
+
+	@Test
+	public void testMain() throws IOException {


Issue found: JUnit tests should include assert() or fail()

bdelion · 2020-03-03T22:05:31Z

+  WireMockServer wireMockServer;
+
+  @BeforeEach
+  public void setup() {


Issue found: You may have misspelled a JUnit framework method (setUp or tearDown)

bdelion · 2020-03-03T22:05:32Z

+import java.nio.channels.ReadableByteChannel;
+import java.util.Properties;
+
+public class MavenWrapperDownloader {


Issue found: All classes and interfaces must belong to a named package

bdelion · 2020-03-03T22:05:34Z

+import java.nio.channels.ReadableByteChannel;
+import java.util.Properties;
+
+public class MavenWrapperDownloader {


Issue found: All classes, interfaces, enums and annotations must belong to a named package

bdelion · 2020-03-03T22:05:34Z

+        } catch (Throwable e) {
+            System.out.println("- Error downloading");
+            e.printStackTrace();
+            System.exit(1);


Issue found: System.exit() should not be used in J2EE/JEE apps

bdelion · 2020-03-03T22:05:35Z

+	 */
+	@Test
+	public void contextLoads() {
+		assertTrue(true);


Issue found: assertTrue(true) or similar statements are unnecessary

Repository owner deleted a comment Oct 30, 2019

Repository owner deleted a comment Nov 3, 2019

Repository owner deleted a comment Nov 4, 2019

bdelion and others added 11 commits February 2, 2020 16:52

♻️💥🚚💩 Rework all the project

f27144e

For #29

📦Make a executable Jar

ca0f8fe

✨ Make work again

✅ Add TU

8e3215b

⏪ Rollback on junit-jupiter

🚧 Add Rain, Snow and other missed informations

2894747

✅ Add json file for Rain and Snow Unit Tests

✅ Add Rain and Snow Unit Test

b7447ac

✨ Add path param for metric and lang

7f79086

Fix #31

🚧 ✅ New Unit Test

dcfdeae

🚚 src-old sources

⬆️ log4j to 2.12.1

83514b1

➕ org.apache.logging.log4j:log4j-slf4j-impl

🔥 Delete src-old copy directory

f5e7933

✅ Add testResultReturnIfCityFoundByZipCode

3fd5b89

🔊 Rework logs

💩 🚧 Work around pom.xml

767179c

bdelion force-pushed the feature/issue-29 branch from 86b016b to 767179c Compare February 2, 2020 16:03

Repository owner deleted a comment Feb 2, 2020

💩 Après compare avec develop

58f36e5

bdelion commented Mar 3, 2020

View reviewed changes

Conversation

bdelion commented Oct 30, 2019

Uh oh!

codecov Bot commented Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bdelion commented Mar 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov Bot commented Oct 30, 2019 •

edited

Loading