Skip to content

PERF: Optimize Reader.TypeDeserializerCache.cs #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
perf-cat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PERF: Optimize Reader.TypeDeserializerCache.cs #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/XmlGridReader.Benchmarks/Benchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
namespace XmlGridReader.Benchmarks
{
[RankColumn(NumeralSystem.Arabic)]
[MemoryDiagnoser]
public class Benchmarks
{
private string xml;
Expand Down
6 changes: 3 additions & 3 deletions src/XmlGridReader/Reader.TypeDeserializerCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ private Func<XmlGridRowReader, object> GetDeserializer(
{
reader.ReadRow();

if (!reader.Columns.Any())
if (reader.Columns.Count == 0)
{
throw new InvalidOperationException("No columns");
}
Expand Down Expand Up @@ -97,12 +97,12 @@ private int ComputeHashCode(List<string> fields)

public bool Equals(DeserializerKey other)
{
if (hashCode != other.hashCode || fields.Count() != other.fields.Count())
if (hashCode != other.hashCode || fields.Count != other.fields.Count)
{
return false;
}

for (int i = 0; i < fields.Count(); i++)
for (int i = 0; i < fields.Count; i++)
{
if (fields[i] != other.fields[i])
{
Expand Down