Closed
Conversation
Owner
|
Thank you for the PR! The implementation goes in a nice direction but there are a few issues:
I'd suggest we close this and move the discussion to #10 to avoid duplication and improve the context of all involved. I'm studying solutions and the one suggested there has a small compromise I'm willing to make if we can't find a perfect fix. Again, thank you so much for opening this! |
Author
|
Data and error are in the wrong order, easy fix, but more importantly the only way I found to simulate a tuple is by extending a full fledge array and any attempt to alter the array type result in a type down of the tuple into a simple array-like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.