Skip to content

Incorrect definition of SLEWCTRL_FAST in include/dt-bindings/pinctrl/am33xx.h #16

@chdh

Description

@chdh

The following definition in am33xx.h is wrong:

#define SLEWCTRL_FAST           (1 << 6)

A correct definition would be:

#define SLEWCTRL_FAST           (0 << 6)      /* dummy, fast is default */
#define SLEWCTRL_SLOW           (1 << 6)

References:

  1. It was correct in the Rowboat kernel: mux.h:
#define AM33XX_SLEWCTRL_FAST            (0 << 6)
#define AM33XX_SLEWCTRL_SLOW            (1 << 6)
  1. AM335x Technical Reference Manual

Section "9.2.2 Pad Control Registers": Bit 6 SLEWCTRL: 0 = Fast, 1 = Slow
Section "9.3.1.50 conf_<module>_<pin> Register": Bit 6, Field conf_<module>_pin_slewctrl: Select between faster or slower slew rate. 0 = Fast, 1 = Slow.

  1. meta-ti message from Peter A. Bigot: "mis-definition of SLEWCTRL_FAST in dt-bindings amxxxx header"

  2. TI forum discussion: AM335x Slew rate setup in the device tree

  3. It's not fixed at kernel.org

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions