Cleaning up old stuff - including old likelihood native libraries #1189
+710
−77,014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
am seeing this error: and many, many other errors. @rambaut -- can this wait until after our ..0 release? |
Contributor
Author
|
The tests all used the old TreeLikelihood and likelihood core. Which is not much use. I am not sure our unit tests are really worth it at present. |
# Conflicts: # src/dr/app/beauti/generator/ClockModelGenerator.java # src/dr/evomodel/tree/HiddenLinkageModel.java # src/test/dr/inference/mcmc/MCMCTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large purge of obsolete stuff starting with the
oldevomodel/*andoldevomodelxml/packages that are based around the originalTreeLikelihoodthat usesTreeLikelihoodCore- the original native library. Most uses of this package were simply to get constant strings for parsers that were also available in newer files.The biggest loss is the whole of the
evomodel.argpackage which was entirely dependent onoldevolmodel. It was easiest to delete it. Legacy use can be through BEAST v1.10.4 and at some point someone can reimplement using BEAGLE tree likelihoods.There were a few other things that were easier to delete than to update and have likely been unused for years.