465 discogs: Fetch a few more metadata fields

[thedevilisinthedetails]

No description provided.

[sampsyo]

Looks good at a high level so far! Can you please leave a comment with some background when you're ready for a review?

[thedevilisinthedetails]

Sure. So I'm grabbing the additional fields (release date, genre and release id) mentioned in the issue and storing them in the db. For the release I just extracted it from the URI. Genre behaves the same as style (for consistency) and just grabbing the release date.

[sampsyo]

OK, cool! It looks like the three fields are genre, discogs_release_id, and released_date.

• genre: Seems harmless enough! We already support this field.
• discogs_release_id: This will be nice to have. Let's think carefully about consistent naming, however. The current MB equivalent is called mb_albumid. Would it make sense to use the same pattern, i.e., discogs_albumid? I don't feel strongly about any of this, but it's worth weighing. Also, I'm not certain this needs to be a built-in fixed field—maybe it's best left out of library.py if it's never going to have a metadata tag?
• released_date: We already have release date information in the year, month, and day fields. Is this different information?

[thedevilisinthedetails]

addressed your comments @sampsyo

[sampsyo]

Awesome; thank you!! Merged with a changelog entry. ✨

[Freso]

Based on my quick skimming of the code, it doesn’t seem like this stops writing Discogs ID(s) as MusicBrainz ones? Any chance you could fix that as well? 🙏 #604

[thedevilisinthedetails]

Based on my quick skimming of the code, it doesn’t seem like this stops writing Discogs ID(s) as MusicBrainz ones? Any chance you could fix that as well? 🙏 #604

You sure? When I import using discogs my files are tagged via discogs metadata values. I mean I see that correct values being added in my db