Skip to content

Add option to force forward slashes in paths #3334

Merged
sampsyo merged 13 commits intobeetbox:masterfrom
MartyLake:martylake_add_forward_slash_option
Jul 25, 2019
Merged

Add option to force forward slashes in paths #3334
sampsyo merged 13 commits intobeetbox:masterfrom
MartyLake:martylake_add_forward_slash_option

Conversation

@MartyLake
Copy link
Copy Markdown

closes #3331

@MartyLake
Copy link
Copy Markdown
Author

Hope the CI gets green =) FYI @sampsyo

Copy link
Copy Markdown
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Any chance you could add the new option to the documentation for both plugins? (See the .rst files in the docs directory.)

@MartyLake
Copy link
Copy Markdown
Author

Thanks for the big review ! I have (if I am not mistaken) integrated all your suggestions and some doc. You can take another look @sampsyo =)

@MartyLake MartyLake force-pushed the martylake_add_forward_slash_option branch from 0080c24 to 076a82d Compare July 23, 2019 22:10
@sampsyo
Copy link
Copy Markdown
Member

sampsyo commented Jul 23, 2019

Cool! Could you take a look at the CI results? Looks like the new test is failing:
https://travis-ci.org/beetbox/beets/jobs/562817055#L915

And the style checker has some suggestions:
https://travis-ci.org/beetbox/beets/jobs/562817056#L1102-L1103

@MartyLake
Copy link
Copy Markdown
Author

MartyLake commented Jul 24, 2019 via email

@sampsyo
Copy link
Copy Markdown
Member

sampsyo commented Jul 24, 2019

That's fine, but because all paths in beets are bytestrings, it might be even more accurate to just change the test:

p = br'C:\a\b\c'
a = br'C:/a/b/c'

Because **all** the path are bytestrings
@MartyLake
Copy link
Copy Markdown
Author

Simplified it ! Tell me if you catch other things that went off my radar :)

@sampsyo sampsyo merged commit fb96660 into beetbox:master Jul 25, 2019
sampsyo added a commit that referenced this pull request Jul 25, 2019
…ption

Add option to force forward slashes in paths
sampsyo added a commit that referenced this pull request Jul 25, 2019
@sampsyo
Copy link
Copy Markdown
Member

sampsyo commented Jul 25, 2019

Looks wonderful! Thank you for taking care of this! Merged. 😃 ✨ 🚀

@MartyLake
Copy link
Copy Markdown
Author

MartyLake commented Jul 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

playlist: Add option to force forward slashes in paths

2 participants