fetchart: Use Cover Art Archive thumbnails#3637
Merged
sampsyo merged 1 commit intobeetbox:masterfrom Jun 27, 2020
mtrolley:topic/coverart-thumb
Merged
fetchart: Use Cover Art Archive thumbnails#3637sampsyo merged 1 commit intobeetbox:masterfrom mtrolley:topic/coverart-thumb
sampsyo merged 1 commit intobeetbox:masterfrom
mtrolley:topic/coverart-thumb
Conversation
Contributor
Author
|
Cover Art Archive API reference: https://musicbrainz.org/doc/Cover_Art_Archive/API#.2Frelease.2F.7Bmbid.7D.2F.28.7Bid.7D.7Cfront.7Cback.29-.28250.7C500.7C1200.29 Tested manually by setting the
|
sampsyo
reviewed
Jun 27, 2020
Member
sampsyo
left a comment
sampsyo
left a comment
There was a problem hiding this comment.
Awesome; seems great! Could you please add a quick entry to the changelog describing what has changed?
sampsyo
reviewed
Jun 27, 2020
Member
sampsyo
left a comment
sampsyo
left a comment
There was a problem hiding this comment.
Just one thought to avoid some unpredictable mutation.
The Cover Art Archive API offers pre-resized thumbnails of cover art. If the `maxwidth` option of `fetchart` matches one of the supported Cover Art Archive thumbnail sizes fetch it directly instead of fetching the full size image then resizing it.
Member
|
Looks excellent; thanks again! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cover Art Archive API offers pre-resized thumbnails of cover
art. If the
maxwidthoption offetchartmatches one of thesupported Cover Art Archive thumbnail sizes fetch it directly
instead of fetching the full size image then resizing it.