fix: dont deduplicate matches if musicbrainz ID is not set for album matches#4299
Merged
sampsyo merged 3 commits intobeetbox:masterfrom Feb 27, 2022
Conversation
Member
|
Looks great to me overall! Would you mind adding a quick changelog entry, and then we can merge this? |
Member
|
Looks great; thanks!! Slightly tweaked the wording, but this is good to go. 🙏 |
Neurrone
deleted the
fix/dont-deduplicate-results-when-musicbrainz-id-is-not-set
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First discussed in #4269 (reply in thread)
Description
Fixes album candidates being treated as duplicates when the album id (assumed to be musicbrainz id) is not set.
(...)
To Do
docs/to describe it.)docs/changelog.rstnear the top of the document.)