An opinionated fix for "the albumtype(s) problem"#5075
An opinionated fix for "the albumtype(s) problem"#5075JOJ0 wants to merge 7 commits intobeetbox:masterfrom
Conversation
We fetch albumtypes from another endpoint anyway.
instead of (single) albumtype string field.
instead of (single) albumtype string attribute. According to Spotify's API docs the album endpoint will always return a single value as a string.
instead of (single) albumtype string attribute. According to Deezer's API docs the album endpoint will always return a single value as a string.
Remove from AlbumInfo and TrackInfo classes.
|
This |
|
Not a contributor, nor is my knowledge of beets internals on a sufficient level to offer technical insight, but as someone who's been using this project for several years (thanks!), this fix seems fine. I don't care for the |
I'm not sure if it's that easy. Will assigning the string from |
Initially I thought I don't care about it either, but now I learned that we can't simply get rid of it, there is too many plugins that still want to use it! So, yeah basically what @arsaboo said is a good idea, let's discuss the technical ways to do that. |
|
Just thinking aloud here. How about having some helper function to translate between |
|
As @shreyasminocha mentioned this has been superseded by #5540 |
4 participants
Description
Addresses parts of #4715
This fix is of the type "works for me" and I'd like to open the discussion and test for others. In my opinion most of the problems we have with
albumtypesandalbumtypefighting against each other is because it just does not make sense to save both of them in beets. No matter where the real problem is, in the end it should be sufficient to save the data once in the beets library, hence only in the multifieldalbumtypes. I'm proposing to kick outalbumtypefrom beets entirely!This fix does not require any changes to mediafile
Furthermore this fixes saving
albumtypesfor the Discogs, the Spotify and the Deezer plugin. Previously populatingalbumtypewas implemented theoratically but broken, andalbumtypeswas not implemented. (I only recently realized this while working on this fix, please tell me if there is open issue for that already, so I can attach them to this PR, thanks!)A nice side effect of the latter fix is that files that where tagged using one of those plugins, can finally be used correctly by the albumtypes plugin as well 🎉
To Do
albumtypesinstead ofalbumtype