Skip to content

Remove unused functions#5103

Merged
Serene-Arc merged 2 commits intobeetbox:masterfrom
Josef-Friedrich:remove-unused-functions
Mar 1, 2024
Merged

Remove unused functions#5103
Serene-Arc merged 2 commits intobeetbox:masterfrom
Josef-Friedrich:remove-unused-functions

Conversation

@Josef-Friedrich
Copy link
Copy Markdown
Contributor

@Josef-Friedrich Josef-Friedrich commented Feb 10, 2024

Description

Remove unused functions. Fixes #5103.

The function ex_varassign is never called. The function ex_lvalue is only called by ex_varassign.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

The function ex_varassign is never called. The function ex_lvalue
is only called by ex_varassign.
@Serene-Arc
Copy link
Copy Markdown
Contributor

Hi, your PR has failed the formatting test. If you could format your PR, that would be appreciated.

@Josef-Friedrich
Copy link
Copy Markdown
Contributor Author

Josef-Friedrich commented Feb 12, 2024

If I run tox locally format_check passes ... strange ...

@Serene-Arc
Copy link
Copy Markdown
Contributor

I just saw it in another PR too, with the same files. I'll have to investigate but it isn't your PR specifically. Sorry, my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants