Use the documented prototype for task factories. #3395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchehab
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Works for me. Tested with both Python 3.13.2 (Fedora 41) and Python 3.13.3 (Fedora 42).
Tested-by: Mauro Carvalho Chehab mchehab@kernel.org
mhsmith
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3394
Python 3.13.3 ensured that the
nameargument was passed down to task factories; this exposed a bug in Toga's task factory wrapper, as it didn't accomodate thenameargument. A task factory is documented as having the prototypefactory(loop, coro, **kwargs); this modifies the Toga definitions to match that prototype. It can be assumed that the arguments passed to the factory will be internally compatible with Task, as they should be version locked with respect to features.PR Checklist: