Skip to content

Fix accumulator methods#33

Merged
belchior merged 14 commits into
mainfrom
fix-accumulator-methods
Oct 30, 2024
Merged

Fix accumulator methods#33
belchior merged 14 commits into
mainfrom
fix-accumulator-methods

Conversation

@belchior
Copy link
Copy Markdown
Owner

@belchior belchior commented Oct 16, 2024

Accumulator methods don't remove calls with empty string and produces invalid sql syntax

use sql_quer_builder as sql;

let query = sql::Select::new()
  .select("")
  .select("login")
  .as_string();
let expected_query = "select login";

assert_eq!(query, expected_query);
failures:

Diff < left / right > :
<SELECT , login
>SELECT login

@belchior belchior self-assigned this Oct 16, 2024
@belchior belchior linked an issue Oct 17, 2024 that may be closed by this pull request
@belchior belchior added the bug Something isn't working label Oct 17, 2024
@belchior belchior force-pushed the fix-accumulator-methods branch from 26e9096 to 88d1789 Compare October 18, 2024 18:50
@belchior belchior merged commit d3e67e2 into main Oct 30, 2024
@belchior belchior deleted the fix-accumulator-methods branch November 11, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

Refactor all builders to remove calls with empty paramenter

1 participant