Conversation
swmcc
force-pushed
the
feature/dockerise
branch
from
4a0a2be to
fed7414
Compare
swmcc
force-pushed
the
feature/dockerise
branch
from
fed7414 to
229e4c6
Compare
pablobm
left a comment
pablobm
left a comment
There was a problem hiding this comment.
Thank you for starting work on this! I've been playing with it and I couldn't initially get it to work :-( Eventually I tweaked things here and there and was able to put together a Docker config that I think does the job?
I have created my own branch, based off this one. You can see it at feature/dockerise...pablobm:docker-take-2 These are some highlights:
- Hex and NPM packages are both included in the image, and cached to a volume. (Note that this means building them twice sometimes.)
- Separates copying the source code from copying the dependency description files (
mix.*,package*.json). This way dependencies are not re-fetched when code changes across image builds. - Database data is saved to a volume, and therefore persisted across runs.
- Automatic page reloads on code changes.
All these changes are inspired by the excellent book Docker for Rails Developers, which I very much recommend! Issues are my fault, successes to be credited to the book. Otherwise, I'm very new to Docker so someone please provide feedback!
| @@ -0,0 +1,4 @@ | |||
| $xport POSTGRES_USER='swm' | |||
| $xport POSTGRES_USER='swm' | ||
| export POSTGRES_PASSWORD='' | ||
| export POSTGRES_DB='website_dev' | ||
| export POSTGRES_HOST='localhost' |
There was a problem hiding this comment.
In fact, was this file intended to be committed?
|
|
||
| set -e | ||
|
|
||
| until psql -h db -U "postgres" -c '\q' 2>/dev/null; do |
There was a problem hiding this comment.
I couldn't get this to work but, after looking around for a bit, I saw that it'll pick up the envvars automatically if they have the names PGUSER, PGPASSWORD, PGHOST, PGDATABASE. Then it works and doesn't need the -h db -U postgres options.
If the envvars change, then they need to change also on other references in the context of the web container (but not the db container, which uses it's own names POSTGRES_*).
| ### Natively | ||
|
|
||
|
|
||
| * export your env vars via `local.env.template` (this isn't loaded so amend, copy, paste and execute). |
There was a problem hiding this comment.
We could instruct users to do source local.env.template.
|
|
||
| RUN apk add postgresql-client | ||
| RUN apk add nodejs | ||
| RUN apk add --update npm |
There was a problem hiding this comment.
If we install inotify-tools, we get automatic page reload on code changes.
| COPY deps/phoenix deps/phoenix | ||
| COPY deps/phoenix_html deps/phoenix_html | ||
|
|
||
| RUN mix local.hex --force |
There was a problem hiding this comment.
I think this should come before line 10 (which copies the code onto the image). This way, a code change doesn't bust the image cache.
|
|
||
| RUN mix local.hex --force | ||
|
|
||
| RUN cd assets && npm install |
There was a problem hiding this comment.
Similarly here. Moving npm install to before copying the code (separating copying the code and copying the package*.json files) would avoid busting the cache on every code change.
2 participants
Created a very quick docker runnable instance of the repo. This is simply to solve people coming to the meetups and not being able to get an instance up and running locally.
We can smart this up later...
etc