Skip to content

HTML ID & Script #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 9 commits into from
Nov 6, 2021
Merged

HTML ID & Script #216

mergify merged 9 commits into from
Nov 6, 2021

Conversation

@DevinWinando
Copy link
Contributor

@DevinWinando DevinWinando commented Nov 5, 2021 •
edited by kingramzy
Loading

Deskripsi (Description)

Checklist:

Umum:
  • Saya menambah kode basic terbaru.
  • Saya memperbaiki kode basic yang sudah ada.
  • Saya menambah template terbaru.
  • Saya memperbaiki template yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • os = windows

Testing

  • link html
  • lint css

linked issue #NOMOR_ISSUE

@mergify mergify bot requested review from a team November 5, 2021 23:42
@DevinWinando
fix: menghapus .vscode
c7c3fb2 
maaf om, saya lupa buat gitignore jadi .vscodenya kebawa
kingramzy
kingramzy approved these changes Nov 6, 2021
View reviewed changes
Copy link
Collaborator

@kingramzy kingramzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mergify mergify bot requested a review from a team November 6, 2021 03:13
@kingramzy kingramzy added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 6, 2021
AdityaFitrianaNS
AdityaFitrianaNS approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@AdityaFitrianaNS AdityaFitrianaNS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tpi itu PRnya double

@mergify mergify bot requested a review from a team November 6, 2021 04:10
@dhafitf dhafitf removed their assignment Nov 6, 2021
@AdityaFitrianaNS AdityaFitrianaNS self-requested a review November 6, 2021 04:55
@DevinWinando DevinWinando self-assigned this Nov 6, 2021
@kimmyxpow kimmyxpow mentioned this pull request Nov 6, 2021
Open
16 tasks
@DevinWinando
Copy link
Contributor Author

DevinWinando commented Nov 6, 2021

wahh makasih om @abinoval udah dibenerin

@DevinWinando
Copy link
Contributor Author

DevinWinando commented Nov 6, 2021 •
edited
Loading

LGTM, tpi itu PRnya double

Double yang mana om? semalem PR #215 emang saya yang buat tapi saya close gara-gara galolos commitCheck, terus PR ulang disini #216

@AdityaFitrianaNS
Copy link
Contributor

AdityaFitrianaNS commented Nov 6, 2021

LGTM, tpi itu PRnya double

Double yang mana om? semalem PR #215 emang saya yang buat tapi saya close gara-gara galolos commitCheck, terus PR ulang disini #216

Eh sorry salah liat om, oke sip aman

@mergify mergify bot requested a review from a team November 6, 2021 07:52
@mergify mergify bot requested a review from a team November 6, 2021 08:09
@kimmyxpow
Copy link
Member

kimmyxpow commented Nov 6, 2021

wahh makasih om @abinoval udah dibenerin

Siap ommm

dhafitf
dhafitf approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semua typo sepertinya sudah diperbaiki. LGTM

@mergify mergify bot requested a review from a team November 6, 2021 11:58
@dhafitf dhafitf added the ready-to-merge siap merge label Nov 6, 2021
@mergify
Copy link

mergify bot commented Nov 6, 2021

terima kasih atas kontribusinya @DevinWinando !

@mergify mergify bot merged commit 4c25dce into bellshade:main Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kingramzy kingramzy kingramzy approved these changes

@miroocloud miroocloud miroocloud approved these changes

@dhafitf dhafitf dhafitf approved these changes

+1 more reviewer

@AdityaFitrianaNS AdityaFitrianaNS AdityaFitrianaNS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DevinWinando DevinWinando

Labels

documentation Improvements or additions to documentation enhancement New feature or request html files markdown files ready-to-merge siap merge request docs team untuk review request tim html untuk review sudah direview !

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DevinWinando @AdityaFitrianaNS @kimmyxpow @kingramzy @miroocloud @dhafitf