Skip to content

025 Html head #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kingramzy merged 6 commits into from
Nov 17, 2021
Merged

025 Html head #221

kingramzy merged 6 commits into from
Nov 17, 2021

Conversation

@DevinWinando
Copy link
Contributor

@DevinWinando DevinWinando commented Nov 16, 2021

Deskripsi (Description)

Checklist:

Umum:
  • Saya menambah kode basic terbaru.
  • Saya memperbaiki kode basic yang sudah ada.
  • Saya menambah template terbaru.
  • Saya memperbaiki template yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • os = windows

Testing

  • link html
  • lint css

linked issue #NOMOR_ISSUE

@DevinWinando
add: HTML Head
31dfce5
@DevinWinando
fix: urutan folder
2cff17a 
saya memperbaiki urutan folder dan menyatukan HTML title, link, dan base ke dalam HTML Head
@DevinWinando DevinWinando self-assigned this Nov 16, 2021
@kimmyxpow kimmyxpow requested a review from a team November 16, 2021 14:28
dhafitf
dhafitf approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dhafitf dhafitf mentioned this pull request Nov 16, 2021
Open
16 tasks
rolandowebdev
rolandowebdev reviewed Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@rolandowebdev rolandowebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@nomadkode
Copy link
Contributor

nomadkode commented Nov 16, 2021

yaml nya bagian label perlu di edit ada bot mergefy yg error karena sudah gak ada tim docs.

@dhafitf
Copy link
Member

dhafitf commented Nov 17, 2021

yaml nya bagian label perlu di edit ada bot mergefy yg error karena sudah gak ada tim docs.

Siap

@kingramzy kingramzy added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 17, 2021
kingramzy
kingramzy approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@kingramzy kingramzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oke Mantab

@kingramzy kingramzy merged commit 9bb1d6b into bellshade:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolandowebdev rolandowebdev rolandowebdev approved these changes

@kingramzy kingramzy kingramzy approved these changes

@dhafitf dhafitf dhafitf approved these changes

Assignees

@DevinWinando DevinWinando

Labels

documentation Improvements or additions to documentation enhancement New feature or request markdown files request docs team untuk review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DevinWinando @nomadkode @dhafitf @kingramzy @rolandowebdev @kimmyxpow