Please add latest fixes to swift4 branch#1
Open
Photogad wants to merge 25 commits intobenguild:swift-4from
Open
Please add latest fixes to swift4 branch#1Photogad wants to merge 25 commits intobenguild:swift-4from
Photogad wants to merge 25 commits intobenguild:swift-4from
Conversation
Tested this on iPhone 5s and iPhone 6, and the 10pt margin looked too thin. I conferred with others and we all agreed 14pt looks much more natural. On shorter strings this has no effect, but when wrapping it looks much nicer. Hope you agree.
Actually, since the horizontal constraints were the only concern, I reverted the two vertical constraints. I think this should be fine now.
…n. Guarding against a crash.
Improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add latest fixes to swift4 branch