Replace deprecated defaultProps usage
#298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kym6464
commented
Jun 23, 2023
| "scripts": { | ||
| "prepublishOnly": "npm run build", | ||
| "clean": "rimraf dist", | ||
| "clean": "rimraf dist && rimraf node_modules/.cache", |
Contributor
Author
There was a problem hiding this comment.
rollup was not seeing my changes to types.ts and I had to manually delete this directory to fix it. Figured it'd be good to automate
Owner
|
Thanks @kym6464, very much appreciated. Code looks good and the auto removal of .cache is a nice bonus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default props is deprecated for functional components facebook/react#25699 and gives this error the console:
This PR implements the recommended solution. I ran all the unit test, integration tests, and all of the examples. Everything seems to be working as before!