Skip to content

Use ES6 syntax #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acailly wants to merge 2 commits into from
Closed

Use ES6 syntax #17

acailly wants to merge 2 commits into from

Conversation

@acailly
Copy link

@acailly acailly commented Apr 25, 2017

⚠️ This PR embed this other PR: #16

I used the ES6 syntax since the current one is mark as deprecated in console warnings.

@acailly acailly mentioned this pull request Apr 25, 2017
Open
@benjeffery
Copy link
Owner

benjeffery commented May 2, 2017

Hi,
Thanks for the PR. You've moved plotly to a prop - is there a good argument for this? It breaks one of my current use cases and I can't imagine anyone needing to change the value of the prop?

@acailly
Copy link
Author

acailly commented May 3, 2017

Hi,
It's the only way I know to pass external argument to a React component with the ES6 syntax.
That's the reason 😉

@Scimonster Scimonster mentioned this pull request Aug 9, 2017
Merged
@benjeffery
Copy link
Owner

benjeffery commented Aug 25, 2017

Superseded by #19, closing.

@benjeffery benjeffery closed this Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acailly @benjeffery