Skip to content

Get working maybeCloseOpenSegment #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pfauwadel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Get working maybeCloseOpenSegment #136

Pfauwadel wants to merge 1 commit into from

Conversation

@Pfauwadel
Copy link

@Pfauwadel Pfauwadel commented Sep 1, 2017

Missing pie argument on method

@Pfauwadel
Get working maybeCloseOpenSegment
70ab8d7 
Missing pie argument on method
@Pfauwadel Pfauwadel closed this Sep 1, 2017
@Pfauwadel Pfauwadel reopened this Sep 1, 2017
giupo pushed a commit to giupo/d3pie that referenced this pull request Apr 16, 2018
Get working maybeCloseOpenSegment (benkeen#136) on _segments.js inste…
93b21d7 
…ad of the bundle d3pie.js
Washee
Washee suggested changes Nov 19, 2018
View reviewed changes
Copy link

@Washee Washee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 1964-1966 should be changed accordingly:
d3pie.prototype.closeSegment = function() {
segments.maybeCloseOpenSegment(this);
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Washee Washee Washee requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pfauwadel @Washee