Refactor drs individual overview #502
Conversation
davidlougheed
left a comment
davidlougheed
left a comment
There was a problem hiding this comment.
looking better than before! I think there's more work to be done here to eliminate duplicate code though, especially with experiments result extraction and DRS URL fetching.
|
|
||
| useEffect(() => { | ||
| if (viewableExperimentResultsForIgv.length > 0) { | ||
| dispatch(getIgvUrlsFromDrs(viewableExperimentResultsForIgv)).catch(console.error); |
There was a problem hiding this comment.
I'm pretty sure this action + getFileDownloadUrlsFromDrs basically do the same thing, and so can be combined (both in action and state, by just creating a single state object called urlsByFilename)
There was a problem hiding this comment.
this effect can also do everything useIndividualIgvViewableExperimentResults does instead of having a different hook, since useIndividualIgvViewableExperimentResults return value is only used here.
There was a problem hiding this comment.
that way, experiments don't have to be extracted twice from the biosamples data.
|
|
||
| export const explorerIndividualUrl = (individualID) => `/data/explorer/individuals/${individualID}`; | ||
|
|
||
| export const useIndividualIgvViewableExperimentResults = (individual) => { |
There was a problem hiding this comment.
this is only used once, so this could be put in the useEffect I commented on above
Centralizes drs fetches in ExplorerIndividualContent, adds utils.js hook for IGV-viewable files; parent dispatches all downloads and IGV subset once; removes child dispatches