feat: support traffic.max_concurrency for api server and runner#3864
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3864 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 155 155
Lines 12878 12915 +37
=====================================
- Misses 12878 12915 +37
|
aarnphm
reviewed
May 20, 2023
aarnphm
reviewed
May 20, 2023
5 tasks
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
aarnphm
reviewed
May 22, 2023
aarnphm
previously approved these changes
May 22, 2023
Contributor
aarnphm
left a comment
aarnphm
left a comment
There was a problem hiding this comment.
I think the test is pretty minuscule, but this is LGTM
Contributor
|
Also I suspect the tests might got cancelled because of the timeout. So you might need to increase the default timeout for our github actions. |
Signed-off-by: Frost Ming <me@frostming.com>
bojiang
reviewed
May 26, 2023
Contributor
|
Here we see it will be a breaking change over our configuration. |
frostming
commented
May 26, 2023
aarnphm
approved these changes
May 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frost Ming me@frostming.com
What does this PR address?
This PR adds support for
trafficconfiguration for both API server and runners.The previous
timeoutsetting is moved undertrafficfield plus a new configurationmax_concurrency, which defaults to infinite.Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.