fix: avoid FileSchema string payload fallthrough#5615
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR address?
FileSchema.decode()acceptsstrinputs and starts handling them as UTF-8 file content, but the next branch was a separateifinstead of anelif. As a result, string payloads still fell through to the final invalid-file-type error instead of being written to a temporary file.This keeps
PurePathinputs as paths, handlesstrpayloads as file content, and adds a regression test for that behavior.Validation
.venv/bin/python -m pytest tests/unit/_bentoml_sdk/test_validators.py -q->2 passed in 0.42s.venv/bin/python -m pytest tests/unit/_bentoml_sdk -q->3 passed in 2.64suvx ruff check src/_bentoml_sdk/validators.py tests/unit/_bentoml_sdk/test_validators.py->All checks passed!uvx ruff format --check src/_bentoml_sdk/validators.py tests/unit/_bentoml_sdk/test_validators.py->2 files already formattedBefore submitting:
ruff checkandruff format --checkpassed for the changed files.