Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to use a specific version of the bertron-schema dependency and ensures test data files comply with the updated schema. It also includes minor improvements to deprecation warnings and test documentation.
- Pin bertron-schema dependency to a specific commit hash instead of using the latest version
- Update JSON test data files to use new schema field names (removing "has_" prefixes)
- Replace deprecated
datetime.utcnow()withdatetime.now(UTC)to eliminate pytest warnings
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates bertron-schema dependency to specific commit with detailed comments |
| tests/data/nmdc-example.json | Updates field names to match new schema (removes "has_" prefixes) |
| tests/data/monet-example.json | Updates field names to match new schema (removes "has_" prefixes) |
| tests/data/gold-example.json | Updates field names to match new schema (removes "has_" prefixes) |
| mongodb/ingest_data.py | Replaces deprecated datetime function and updates schema URL to match dependency |
| CONTRIBUTING.md | Adds instructions for running tests in container with colored output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jeff-cohere
approved these changes
Aug 19, 2025
Collaborator
jeff-cohere
left a comment
There was a problem hiding this comment.
Thanks for the helpful comments explaining how to maintain the schema dependencies, Eric!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On this branch, I made three main changes:
bertron-schemarepository.has_prefix from some field names.I also made these minor changes:
pytestoutput appears in color, like this: