Skip to content

Pin bertron-schema version to v0.1.0-alpha.10 using Git tag#91

Merged
eecavanna merged 4 commits intomainfrom
sync-tags
Aug 20, 2025
Merged

Pin bertron-schema version to v0.1.0-alpha.10 using Git tag#91
eecavanna merged 4 commits intomainfrom
sync-tags

Conversation

@shreddd
Copy link
Copy Markdown
Contributor

@shreddd shreddd commented Aug 20, 2025

I'd like to switch to using the tagged version of the schema.

As a one time fix I would also like to update the tag "v0.1.0-alpha.10" on this repo to match this commit.

I realize that this is essentially re-tagging things, but it will allow us to bring all the repos in sync

@eecavanna
Copy link
Copy Markdown
Collaborator

eecavanna commented Aug 20, 2025

As a one time fix I would also like to update the tag "v0.1.0-alpha.10" on this repo to match this commit.

I'd rather not redefine an existing Git tag in this repo, since this repo has a GHA workflow that has already used the tagged commit to build a container image (whose image tag is derived from the Git tag). I'd prefer creating a new tag; e.g. v0.1.0-alpha.11. I'm OK with there being multiple tags pointing to the same commit (which would be the case in the other repos).

Copy link
Copy Markdown
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one exception:

There is one more place where the schema hash is used. It's the default value of one of the CLI options in the ingester.

default="https://raw.githubusercontent.com/ber-data/bertron-schema/82498f5f5cbc71ed7abf71b8e2c01d15c003f8d8/src/schema/jsonschema/bertron_schema.json",

Once that's been updated, I'm OK with this being merged in.

@shreddd
Copy link
Copy Markdown
Contributor Author

shreddd commented Aug 20, 2025

LGTM with one exception:

There is one more place where the schema hash is used. It's the default value of one of the CLI options in the ingester.

default="https://raw.githubusercontent.com/ber-data/bertron-schema/82498f5f5cbc71ed7abf71b8e2c01d15c003f8d8/src/schema/jsonschema/bertron_schema.json",

Once that's been updated, I'm OK with this being merged in.

I agree

@eecavanna
Copy link
Copy Markdown
Collaborator

Sorry, I don't think I used the right syntax. Will fix and commit again.

@eecavanna
Copy link
Copy Markdown
Collaborator

Yeah, I left off the /src/schema/jsonschema/bertron_schema.json (oops)

@eecavanna eecavanna changed the title update schema tag Pin bertron-schema version to v0.1.0-alpha.10 using Git tag Aug 20, 2025
@eecavanna eecavanna merged commit 03c005a into main Aug 20, 2025
1 check passed
@eecavanna eecavanna deleted the sync-tags branch August 20, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants