Conversation
…valuation # Conflicts: # perception/vis/algo_stats # perception/vis/vis.py
| from typing import Tuple | ||
| import sys | ||
| import os | ||
| sys.path.append(os.path.dirname(__file__)) |
There was a problem hiding this comment.
I don't see this line deleted. Is this needed for some reason still?
|
Also why are there 3 different algorithms, A, B, C? is it just older versions? Probably should be renamed better |
nLevin13
left a comment
nLevin13
left a comment
There was a problem hiding this comment.
I noticed that this branch is several commits behind master, so there's a features I added to vis.py that aren't in your version, namely the pyplot integration. Can you merge from master first then apply your changes? Other than that, it seems good
AVSurfer123
left a comment
AVSurfer123
left a comment
There was a problem hiding this comment.
Just 2 more small deletions and its good to go
| @@ -8,10 +8,10 @@ | |||
| ############################################################################# | |||
|
|
|||
| sys.path.insert(0, '../background_removal') | |||
| from typing import Tuple | ||
| import sys | ||
| import os | ||
| sys.path.append(os.path.dirname(__file__)) |
There was a problem hiding this comment.
I don't see this line deleted. Is this needed for some reason still?
|
We can remove (archive) detectGate, threshTest, and threshslider |
3 participants
No description provided.