[0.x] DoctrineDriver: Fix "LIMIT 1FOR UPDATE"

[MatthiasKuehneEllerhold]

Using bernardphp with the doctrine driver produces this invalid SELECT statement:

SELECT id, message FROM bernard_messages
WHERE queue = :queue AND visible = :visible
ORDER BY sentAt, id 
LIMIT 1FOR UPDATE

As you can see there is a space missing between "LIMIT 1" and "FOR UPDATE".

This error exists in 0.12.3 (latest stable) and the 0.x branch. It is fixed in the master though.

This error is thrown and silently ignored in the driver so it never makes it to the consumer. This makes it very hard to notice.

[acrobat]

@sagikazarmark should we still merge this PR and release a new 0.x version? We are working towards 1.0 and this fix is already present in newer versions so a "upgrade" from 0.x to 1.0-alpha would fix this issue

[sagikazarmark]

I have no problem with merging it and tagging as a 0.x patch release. Until 1.0 0.x is the "stable" release branch.

[sagikazarmark]

@acrobat Do you want to merge it or should I?

[acrobat]

Ok thanks for the feedback! I will merge and release!

[acrobat]

Thanks @MatthiasKuehneEllerhold!

[acrobat]

@MatthiasKuehneEllerhold a new version was tagged, see 0.12.4

[MatthiasKuehneEllerhold]

Happy to help.