Replace SQLiteWriter mutex with SQLite mutex#11
Open
wandernauta wants to merge 1 commit intoberthubert:mainfrom
Open
Replace SQLiteWriter mutex with SQLite mutex#11wandernauta wants to merge 1 commit intoberthubert:mainfrom
wandernauta wants to merge 1 commit intoberthubert:mainfrom
Conversation
The SQLiteWriter commit thread and the user's main thread share the same connection to the underlying database. The threads are synchronized with a std::mutex on SQLiteWriter. However, the SQLite connection already carries its own (recursive) mutex which we can use instead. This simplifies the design slightly: there can no longer be a situation where a thread grabs the SQLiteWriter-side lock but has to wait for the SQLite-side lock, which would be very confusing. This will not work in builds of SQLite with non-defualt threading modes, but in such cases sharing a connection among threads is unsafe anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQLiteWriter commit thread and the user's main thread share the same connection to the underlying database. The threads are synchronized with a std::mutex on SQLiteWriter.
However, the SQLite connection already carries its own (recursive) mutex which we can use instead. This simplifies the design slightly: there can no longer be a situation where a thread grabs the SQLiteWriter-side lock but has to wait for the SQLite-side lock, which would be very confusing.
This will not work in builds of SQLite with non-default threading modes, but in such cases sharing a connection among threads is unsafe anyway.