Swallow commit() exception in MiniSQLite destructor, improve state check#8
Open
wandernauta wants to merge 1 commit intoberthubert:mainfrom
Open
Swallow commit() exception in MiniSQLite destructor, improve state check#8wandernauta wants to merge 1 commit intoberthubert:mainfrom
wandernauta wants to merge 1 commit intoberthubert:mainfrom
Conversation
This makes it so that MiniSQLite's destructor only attempts to commit if
a transaction is actually active, and also makes it so that a failure to
commit in the destructor is quietly ignored with no exception thrown.
Before, MiniSQLite carried a boolean flag to indicate whether the SQLite
database being wrapped was in a transaction, but this flag could diverge
from the actual state by...
- the "begin" query or "commit" query failing
- calling code mistakenly doing exec("rollback") or exec("commit")
- automatic rollbacks caused by e.g. disk I/O or disk full errors
In the last case, the error would cause an exception to be thrown, which
would trigger stack unwinding, destroying the MiniSQLite. The MiniSQLite
destructor, not having noticed the autorollback, would attempt a commit,
which would throw another exception, finally reaching std::terminate.
Also adds tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that MiniSQLite's destructor only attempts to commit if a transaction is actually active, and also makes it so that a failure to commit in the destructor is quietly ignored with no exception thrown.
Before, MiniSQLite carried a boolean flag to indicate whether the SQLite database being wrapped was in a transaction, but this flag could diverge from the actual state by...
In the last case, the error would cause an exception to be thrown, which would trigger stack unwinding, destroying the MiniSQLite. The MiniSQLite destructor, not having noticed the autorollback, would attempt a commit, which would throw another exception, finally reaching std::terminate.
Also adds tests.