Sprites created with Draw.is_visible=false are never visible#1008
Closed
msvbg wants to merge 2 commits intobevyengine:masterfrom
Closed
Sprites created with Draw.is_visible=false are never visible#1008msvbg wants to merge 2 commits intobevyengine:masterfrom
msvbg wants to merge 2 commits intobevyengine:masterfrom
Conversation
Moxinilian
added
C-Bug
Member
|
Yeah this definitely works, but it comes at the cost of updating buffers every frame (which is expensive). I just put out a pr that lets us retain incremental binding updates. |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sprites are created with
draw.is_visible = false, the bind group containingTransformandSprite_sizenever gets created. I tried to find a proper solution to the problem, but the renderer code is too complicated for me to fully understand at this point. This solution may be a bit of a cop-out, so I'm okay with it not getting merged. A better solution would perhaps be to make sure that all the necessary bind groups are created when the sprite gets created. This PR does however remove the bug, as far as I can tell.