Change AxisSettings livezone default#10090
Merged
alice-i-cecile merged 5 commits intobevyengine:mainfrom Oct 12, 2023
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Oct 11, 2023
alice-i-cecile
added
the
M-Migration-Guide
Contributor
|
I think rather than changing the individual test cases, we should make the tests use the old settings so that the "live zone rounding" still gets tested. |
rparrett
approved these changes
Oct 12, 2023
Contributor
rparrett
left a comment
rparrett
left a comment
There was a problem hiding this comment.
This makes more sense as a default to me.
Actually, I'm having trouble imagining a scenario where the previous default settings make any sense at all.
alice-i-cecile
added
the
S-Ready-For-Final-Review
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
# Objective While using joysticks for player aiming, I noticed that there was as `0.05` value snap on the axis. After searching through Bevy's code, I saw it was the default livezone being at `0.95`. This causes any value higher to snap to `1.0`. I think `1.0` and `-1.0` would be a better default, as it gives all values to the joystick arc. This default livezone stumped me for a bit as I thought either something was broken or I was doing something wrong. ## Solution Change the livezone defaults to ` livezone_upperbound: 1.0` and `livezone_lowerbound: -1.0`. --- ## Migration Guide If the default 0.05 was relied on, the default or gamepad `AxisSettings` on the resource `GamepadSettings` will have to be changed.
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective While using joysticks for player aiming, I noticed that there was as `0.05` value snap on the axis. After searching through Bevy's code, I saw it was the default livezone being at `0.95`. This causes any value higher to snap to `1.0`. I think `1.0` and `-1.0` would be a better default, as it gives all values to the joystick arc. This default livezone stumped me for a bit as I thought either something was broken or I was doing something wrong. ## Solution Change the livezone defaults to ` livezone_upperbound: 1.0` and `livezone_lowerbound: -1.0`. --- ## Migration Guide If the default 0.05 was relied on, the default or gamepad `AxisSettings` on the resource `GamepadSettings` will have to be changed.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective While using joysticks for player aiming, I noticed that there was as `0.05` value snap on the axis. After searching through Bevy's code, I saw it was the default livezone being at `0.95`. This causes any value higher to snap to `1.0`. I think `1.0` and `-1.0` would be a better default, as it gives all values to the joystick arc. This default livezone stumped me for a bit as I thought either something was broken or I was doing something wrong. ## Solution Change the livezone defaults to ` livezone_upperbound: 1.0` and `livezone_lowerbound: -1.0`. --- ## Migration Guide If the default 0.05 was relied on, the default or gamepad `AxisSettings` on the resource `GamepadSettings` will have to be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
While using joysticks for player aiming, I noticed that there was as
0.05value snap on the axis. After searching through Bevy's code, I saw it was the default livezone being at0.95. This causes any value higher to snap to1.0. I think1.0and-1.0would be a better default, as it gives all values to the joystick arc.This default livezone stumped me for a bit as I thought either something was broken or I was doing something wrong.
Solution
Change the livezone defaults to
livezone_upperbound: 1.0andlivezone_lowerbound: -1.0.Migration Guide
If the default 0.05 was relied on, the default or gamepad
AxisSettingson the resourceGamepadSettingswill have to be changed.