Conversation
alice-i-cecile
left a comment
There was a problem hiding this comment.
Commit one: strongly in favor of.
Commit two: not clear on the motivation of this.
Commit three: a before/after screenshot would be really helpful.
|
Nitpick, but enlarging of names should be discouraged unless it is an new/bespoke concept or term, where as TAA is an industry standard and can be found with a simple google search if someone doesn't know what it stands for. |
The only renames are currently internal, so it's not a breaking change :) |
|
@DGriffin91 thanks for the test! Should be fixed now. The approach I was using before doesn't work with the way TAA is currently setup, so when I pulled it out of the larger changes it wasn't working. |
|
Tested with the example from #10200 and the obvious edge blurring is no longer present. Can't really comment beyond that. |
Extracted the easy stuff from bevyengine#8974 . # Problem 1. Commands from `update_previous_view_projections` would crash when matching entities were despawned. 2. `TaaPipelineId` and `draw_3d_graph` module were not public. 3. When the motion vectors pointed to pixels that are now off screen, a smearing artifact could occur. # Solution 1. Use `try_insert` command instead. 2. Make them public, renaming to `TemporalAntiAliasPipelineId`. 3. Check for this case, and ignore history for pixels that are off-screen.
Extracted the easy stuff from bevyengine#8974 . # Problem 1. Commands from `update_previous_view_projections` would crash when matching entities were despawned. 2. `TaaPipelineId` and `draw_3d_graph` module were not public. 3. When the motion vectors pointed to pixels that are now off screen, a smearing artifact could occur. # Solution 1. Use `try_insert` command instead. 2. Make them public, renaming to `TemporalAntiAliasPipelineId`. 3. Check for this case, and ignore history for pixels that are off-screen.

Extracted the easy stuff from #8974 .
Problem
update_previous_view_projectionswould crash when matching entities were despawned.TaaPipelineIdanddraw_3d_graphmodule were not public.Solution
try_insertcommand instead.TemporalAntiAliasPipelineId.